search

SanderRonde / VSCode-Gerrit

Gerrit plugin for VSCode
https://marketplace.visualstudio.com/items?itemName=SanderRonde.vscode--gerrit
MIT License
29 stars 17 forks source link

Autenticcated config/server/version request #45

Closed ishifman-nvidia closed 1 year ago

ishifman-nvidia commented 1 year ago

Hi in my organization the Gerrit server doesn't permits anonyms users so even the get version should be authenticated
https:///a/config/server/version it seems that current request is not supporting this : GET request to "https://<our_gerit_server>/config/server/version is it possible to handle this? maybe by adding a flag in settings to support getGerritVersion with authentication? or maybe by trying to call getURL with and without authentication?

Thanks

SanderRonde commented 1 year ago

It does do one initial unauthenticated call to /config/server/version but it continues the flow if this request fails. It does indeed show a warning while it shouldn't. I fixed that part and released a new version with it (1.2.14)

The extension will function the same as before though, all API requests that are actually depended on are already all authenticated.

ishifman-nvidia commented 1 year ago

Hi @SanderRonde I appreciate your fast help Problem solved , I am able to use Gerrit again

Thank you again for your help Regards Itai