search

SanderRonde / VSCode-Gerrit

Gerrit plugin for VSCode
https://marketplace.visualstudio.com/items?itemName=SanderRonde.vscode--gerrit
MIT License
31 stars 17 forks source link

Unresolved/Resolved comment filter does not filter #74

Closed Mattadore closed 4 months ago

Mattadore commented 5 months ago

Even if I disable both, I still see all the comments available :(

SanderRonde commented 4 months ago

Which filter do you mean? Maybe I've forgotten some parts of the extension :)

Mattadore commented 4 months ago

image image This button, under the comments tab. It does not seem to do anything if I check/uncheck the filters.

SanderRonde commented 4 months ago

Ah yeah that's not something I added... Think that's native to VSCode and a pretty new feature (at least it wasn't there when I built the extension). Will try to add support for it though.

SanderRonde commented 4 months ago

Yeah it was indeed something new, but luckily pretty easy to integrate since the extension already supported it. Should be live in the next version (1.2.42)