Improve Gerrit icon

[felipecrs]

SVG was taken from https://en.m.wikipedia.org/wiki/File:Gerrit_icon.svg, and pretty-formatted with the XML extension for VS Code.

Then, I used the following tool to generate the PNG in 256x256 which is the size recommended by VS Code.

https://vincerubinetti.github.io/svg-to-png/

[SanderRonde]

Thanks for the PR! The PNG size upgrade is a good change, let's keep that one. But the svg change will actually make the icon look really weird in VSCode (see image below). VSCode turns the colored in SVG into a greyscale one with only filled-in or transparant. The red and green then also turn into grey turning it into a square blob. If you can remove that part of the change from this PR it's all good!

[felipecrs]

You are totally right. I'll see what I can do, otherwise I'll restore the original SVG.

[felipecrs]

I restored the original icon, but pretty-printed it with the SVG extension.

I noticed a very small issue with it:

But I could not fix it, I don't know anything about SVGs lol.

[SanderRonde]

Ah the little bit of space between the svg is fine, you won't see it anyways since it's so tiny. So if you restore the yarn.lock file all good

[felipecrs]

Ah the little bit of space between the svg is fine, you won't see it anyways since it's so tiny. So if you restore the yarn.lock file all good

I actually fixed it in https://github.com/SanderRonde/VSCode-Gerrit/pull/75/commits/acf6609737da3af96266f12641777072d9f55709. :)

[SanderRonde]

Awesome, thanks for the PR! Will merge it as soon as you fix the merge conflicts :)

[felipecrs]

Awesome, thanks for the PR! Will merge it as soon as you fix the merge conflicts :)

Hm... I had fixed already, I believe.

[SanderRonde]

Oh weird github is showing me something else. I'll try and fix it

[SanderRonde]

Ah it was the rebasing, a merge commit was fine. Thanks again for the PR!