search

SanderRonde / phpstan-vscode

PHPStan plugin for VSCode
https://marketplace.visualstudio.com/items?itemName=SanderRonde.phpstan-vscode
MIT License
40 stars 9 forks source link

Silent timeouts #2

Closed ljubadr closed 2 years ago

ljubadr commented 2 years ago

Thanks for making the great extension!

When the phpstan times out it's not really clear that it happened. I never saw extension reporting the error and I only saw it in my git hook. After looking into vscode output for your extension I noticed the timeout. Increasing the timeout solved the problem

Would it be possible to show notification when timeout happens? You could also add setting to hide these notifications

SanderRonde commented 2 years ago

Fix should be live in 1.1.3. Thanks for the suggestion!

ljubadr commented 2 years ago

Thanks for the fast response!

ljubadr commented 2 years ago

I just tested it and it looks good, thanks again!