search

SanderRonde / phpstan-vscode

PHPStan plugin for VSCode
https://marketplace.visualstudio.com/items?itemName=SanderRonde.phpstan-vscode
MIT License
40 stars 9 forks source link

Extension Settings is named wrong #33

Closed finn-matti closed 1 year ago

finn-matti commented 1 year ago

Screenshot 2023-05-04 at 10 53 30

For some reason the extension settings for phpstan-vscode are named incorrectly.

EDIT: For clarification it should be called something like "phpstan".

SanderRonde commented 1 year ago

Hmm do you mean this setting should just be called "phpstan"? I think a name like that is fine when it's just "/usr/bin/phpstan" but in cases where it's more complex (such as when ran in a docker container) a name like "binpath" is more fitting. What do you think?

finn-matti commented 1 year ago

Sorry, for being unclear. Take a look at the sidebar:

Screenshot 2023-05-05 at 10 04 39

You would never guess that "Extension Configuration" is the config for the phpstan extension. It needs to be less generic.

SanderRonde commented 1 year ago

Ah yeah you're right. Weird, will take a look!