search

SandersForPresident / BusRSVP

Reserve a seat on a bus to go to a Bernie Sanders event
Other
7 stars 4 forks source link

A Bernie Bootstrap <h1> #11

Closed eric-johnson closed 9 years ago

eric-johnson commented 9 years ago

Begins SandersForPresident/BusRSVP#2. Created a page so I can see that the styles actually apply. Copy/pasted bootstrap js & css into lib/assets. It looks like these styles are updated frequently, so I'm considering making a rake task to pull down the latest.

bryceroney commented 9 years ago

Instead shouldn't we make bernstrap a proper bower package so that it can be linked as a rails-assets gem?

eric-johnson commented 9 years ago

Probably... I didn't think of that I'll take another stab at it.

bryceroney commented 9 years ago

I've tried to do that here: https://github.com/SandersForPresident/bootstrap/pull/2

maclover7 commented 9 years ago

Looks nice so far, @eric-johnson! Two quick things: (1) Can you move the assets to vendor/assets? That's typically where vendored (external) stylesheets live. (2) Can you combine both of the Rake tasks into a single file, and then stick them under the same namespace? They can live in lib/tasks/berniestrap.rake, and then just stick the tasks under the :berniestrap namespace. Thanks for submitting this PR!

atticoos commented 9 years ago

Can you move the assets to vendor/assets?

Please use bower here and avoid checking in the assets if possible

maclover7 commented 9 years ago

Maybe we can use the rails-assets.org bower-rubygem crossover service?

eric-johnson commented 9 years ago

That thought crossed my mind, but Berniestrap isn't up on bower.io (yet?).

atticoos commented 9 years ago

Why not just use bower? /cc @schneidmaster who just incorporated this in another rails project.

maclover7 commented 9 years ago

Please resolve merge conflicts.

eric-johnson commented 9 years ago

I'm planning on throwing this away and replacing it with this in the Gemfile:

source 'https://rails-assets.org' do
  gem 'rails-assets-berniestrap'
end