search

SandersForPresident / SitesForBernie

SandersForPresident WordPress theme for campaign microsites
http://forberniesanders.com
Other
26 stars 9 forks source link

Add home sidebar widget area template #46

Closed jasonbraun closed 9 years ago

jasonbraun commented 9 years ago

Add page-home-sidebar.php template and widget model for users who want a sidebar home page with widgets.

atticoos commented 9 years ago

We have a few code style standards set up on this project, which is why the build failed:

https://travis-ci.org/SandersForPresident/SitesForBernie/jobs/78939890#L236-L267

jasonbraun commented 9 years ago

Ah ok - I'll take care of this when I get back to a computer.

atticoos commented 9 years ago

No rush :ok_hand:

jasonbraun commented 9 years ago

I thought I had it after I fixed the spacing, but I keep getting this error, inline control structures not allowed, I think it's because I need to close with an else statement? But this is the way I've always done it. Let me know.

FILE: ...s/build/SandersForPresident/SitesForBernie/page-home-sidebar.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 22 | ERROR | [x] Inline control structures are not allowed
    |       |     (Generic.ControlStructures.InlineControlStructure.NotAllowed)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 1.48 secs; Memory: 6.5Mb
jasonbraun commented 9 years ago

Alright I think I got it, build passes, yay!

atticoos commented 9 years ago

Awesome, thanks for cleaning up the build :smile: :+1: