search

Sandertv / gophertunnel

General purpose library for Minecraft Bedrock Edition software written in Go
MIT License
419 stars 95 forks source link

Minor correction #158

Closed DJStompZone closed 1 year ago

DJStompZone commented 1 year ago

Added missing text packet type TextTypeTranslation to doc comments for NeedsTranslation and Parameters

JustTalDevelops commented 1 year ago

For future reference - that list isn't meant to be a full list of text types, but rather just a sample of the text types, as the 'include' should indicate.

DJStompZone commented 1 year ago

For future reference - that list isn't meant to be a full list of text types, but rather just a sample of the text types, as the 'include' should indicate.

I guess I was thrown off by the current wording,

These parameters are only written if the type of the packet is TextTypeTip, TextTypePopup or TextTypeJukeboxPopup.

JustTalDevelops commented 1 year ago

Ah, those are in two different sections. It might make sense to update the other section to be more specific.