Sandertv / gophertunnel

General purpose library for Minecraft Bedrock Edition software written in Go
MIT License
423 stars 96 forks source link

Horion Client crasher type 6 crashing dragonfly server! #186

Closed VinkyV closed 1 year ago

VinkyV commented 1 year ago

Horion Client crasher type 6 crashing dragonfly server! Server starting using all free memory and crashing sometimes with PC.

Suggested idea to fix t from BDSX (NodeJS server core above BDS) by https://discord.com/channels/646456965983240212/1105441694498955364/1105441694498955364

import { events } from "bdsx/event";
import { bedrockServer } from "bdsx/launcher";
import { MinecraftPacketIds } from "bdsx/bds/packetids";
import { CANCEL } from "bdsx/common";

events.packetRaw(MinecraftPacketIds.PlayerList).on((ptr, size, ni) => {
    if(size == 0x7) {
        bedrockServer.serverInstance.disconnectClient(ni, `crasher-a (horion type 6 crasher)`);
        return CANCEL;
    };
});

Suggested check if PlayerList packet size == 0x7 and then kick client

Dragonfly version: 1877140 Architecture: AMD x64 OS: Windows 10 x64 Client: Minecraft 1.19.81 x64

Sandertv commented 1 year ago

This is fixed in the latest versions. Thank you for reporting.