Module path should be "github.com/Sandertv/mcwss", not "github.com/sandertv/mcwss"

KateGo520 commented 4 years ago

Background

Module path is inconsistent with go import path. GO111MODULE=on, as README said, run go get github.com/Sandertv/mcwss:

go: downloading github.com/Sandertv/mcwss v1.2.0
go: github.com/Sandertv/mcwss upgrade => v1.2.0
go get: github.com/Sandertv/mcwss@v1.2.0: parsing go.mod:
        module declares its path as: github.com/sandertv/mcwss
                but was required as: github.com/Sandertv/mcwss

Solution

Fix the module path:

1) Rename the module path to "github.com/Sandertv/mcwss": https://github.com/Sandertv/mcwss/blob/master/go.mod#L1

module github.com/Sandertv/mcwss
require (
    …
)

2) Change the README document to use go get github.com/sandertv/mcwss.

KateGo520 commented 4 years ago

@Sandertv @Tsubashi Could you help me review this issue? Thx :p

Sandertv commented 4 years ago

For backwards compatibility reasons I don't think renaming the module is an option. I'll change the README to use all lowercase.

Sandertv commented 4 years ago

Should be fixed in 0244b379697bf0021212c2587d6234eba26aef48, let me know if that is sufficient.

KateGo520 commented 4 years ago

@Sandertv I think that's sufficient. Thank you for your reply.

Sandertv / mcwss