search

Sandia-OpenSHMEM / SOS

Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4, the Open Fabric Interface (OFI), and UCX. Please click on the Wiki tab for help with building and using SOS.
Other
61 stars 53 forks source link

Add error checking for objects on external heap #1116

Closed philipmarshall21 closed 4 months ago

philipmarshall21 commented 5 months ago

Now checking if an object resides on the external heap when determining if said object is symmetric. This PR also revises the overlap check to allow overlap in target and source buffers for RMA operations if target_pe != source_pe

philipmarshall21 commented 5 months ago

Not convinced the change to SHMEM_ERR_CHECK_SYMMETRIC_HEAP is quite correct yet

philipmarshall21 commented 4 months ago

Seems like the overlap checks are missing entirely from data_f.c, synchronization_f.c, and collectives_f.c. Are those files still being maintained / does the SHMEM_ERR_CHECK_OVERLAP check need to be added to them?

davidozog commented 4 months ago

Seems like the overlap checks are missing entirely from data_f.c, synchronization_f.c, and collectives_f.c. Are those files still being maintained / does the SHMEM_ERR_CHECK_OVERLAP check need to be added to them?

That’s probably not a concern, those are for Fortran interfaces, which are all deprecated.