Closed philipmarshall21 closed 4 months ago
Not convinced the change to SHMEM_ERR_CHECK_SYMMETRIC_HEAP is quite correct yet
Seems like the overlap checks are missing entirely from data_f.c, synchronization_f.c, and collectives_f.c. Are those files still being maintained / does the SHMEM_ERR_CHECK_OVERLAP check need to be added to them?
Seems like the overlap checks are missing entirely from data_f.c, synchronization_f.c, and collectives_f.c. Are those files still being maintained / does the SHMEM_ERR_CHECK_OVERLAP check need to be added to them?
That’s probably not a concern, those are for Fortran interfaces, which are all deprecated.
Now checking if an object resides on the external heap when determining if said object is symmetric. This PR also revises the overlap check to allow overlap in target and source buffers for RMA operations if
target_pe != source_pe