Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4, the Open Fabric Interface (OFI), and UCX. Please click on the Wiki tab for help with building and using SOS.
Other
61
stars
53
forks
source link
Teams: move warning to debug message for config_mask==0 and config == null #1138
As discussed in #1122, this warning may not be necessary, especially with some upcoming proposed changes to the specification to clarify this special case.
For now this PR changes this to a debug message, so at least users will not see any message unless the env var SHMEM_DEBUG=1 is set.
I could likely be convinced to remove this message entirely, but given the state of the OpenSHMEM v1.5 spec, which is unclear as to whether a null config argument is acceptable, a debug message might be a better "compromise".
@dalcinl @stewartl318 @mrogowski - I invited you as collaborators to review, you'll need to accept it in email.
As discussed in #1122, this warning may not be necessary, especially with some upcoming proposed changes to the specification to clarify this special case.
For now this PR changes this to a debug message, so at least users will not see any message unless the env var
SHMEM_DEBUG=1is set.I could likely be convinced to remove this message entirely, but given the state of the OpenSHMEM v1.5 spec, which is unclear as to whether a null
configargument is acceptable, a debug message might be a better "compromise".@dalcinl @stewartl318 @mrogowski - I invited you as collaborators to review, you'll need to accept it in email.