search

Sandia-OpenSHMEM / SOS

Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4, the Open Fabric Interface (OFI), and UCX. Please click on the Wiki tab for help with building and using SOS.
Other
61 stars 53 forks source link

OFI: probe operation assumes fi_cq_read returns 1 is unexpected #1141

Closed davidozog closed 2 months ago

davidozog commented 2 months ago

The OFI shmem_transport_probe operation assumes fi_cq_read returning 1 is an "Unexpected event", but this is probably wrong according to a recent man page:

fi_cq_read / fi_cq_readfrom:
On success, returns the number of completions retrieved from the completion queue.
davidozog commented 2 months ago

This is a false alarm. The count argument is 1 so probe reads for only 1 event. However, the man page says:

A count value of 0 may be used to drive progress on associated endpoints when manual progress is enabled.

so maybe 0 would be a better choice... but closing for now.