Sandia-OpenSHMEM / SOS

Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4, the Open Fabric Interface (OFI), and UCX. Please click on the Wiki tab for help with building and using SOS.
Other
61 stars 53 forks source link

RMA operations with context argument need to check/retrieve PE ID relative to team associating with the context #1143

Open wrrobin opened 2 weeks ago

wrrobin commented 2 weeks ago

From the spec,

The destination PE is specified as an integer representing the PE number. This PE number is relative to the team
associated with the communication context being using for the operation. If no context argument is passed to the
routine, then the routine operates on the default context, which implies that the PE number is relative to the world
team. If the PE number passed to the routine is invalid, being negative or greater than or equal to the size of the
OpenSHMEM team, then the behavior is undefined.

SOS currently is missing the check for PE ID relative to the team associated with the context. All PE IDs are treated as relative to TEAM_WORLD.