SandroGrzicic / ScalaBuff

the scala protocol buffers (protobuf) compiler
Other
219 stars 80 forks source link

Only use backticks for reserved/invalid identifiers #114

Closed iantabolt closed 9 years ago

iantabolt commented 9 years ago

This PR is closely related to #20, and partially reverts some of the behavior. Rather than adding backticks to every identifier, the change only adds them to:

  1. reserved keywords (type, val, etc), and
  2. invalid identifiers (things with symbols, spaces, etc - may not be needed because of .proto restrictions).

All other identifiers are left alone.

The main motivation behind this is that some IDEs (cough IntelliJ) do not do well with backticks and code completion. This makes it a real pain to write code that uses classes generated by ScalaBuff.

SandroGrzicic commented 9 years ago

Looks good. Thanks.