search

SandroMachado / openalpr-android

Android Automatic License Plate Recognition library (http://www.openalpr.com) ported for android.
Apache License 2.0
770 stars 272 forks source link

Multiple code quality fix-1 #27

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S00116- Field names should comply with a naming convention. squid:S00117- Local variable and method parameter names should comply with a naming convention. You can find more information about the issues here: https://dev.eclipse.org/sonar/rules/show/squid:S00116 https://dev.eclipse.org/sonar/rules/show/squid:S00117

Please let me know if you have any questions.

Faisal Hameed

SandroMachado commented 8 years ago

@faisal-hameed please rebase.

faisal-hameed commented 8 years ago

@SandroMachado Rebased.

SandroMachado commented 8 years ago

This cannot be done like this, if you change the objects fields name they will not match to the results generated by the OpenALPR framework and this (https://github.com/SandroMachado/openalpr-android/blob/4aeb0dbddddb06bc993e28b95a0845d0a98e9c71/Sample/OpenALPRSample/app/src/main/java/com/sandro/openalprsample/MainActivity.java#L88) will fail.

faisal-hameed commented 8 years ago

@SandroMachado Rebased. Resolved conflicts caused by other commits.

SandroMachado commented 8 years ago

@faisal-hameed it is not possible to change the field names, since the field names are used to match the json response from the OpenAPLR.

faisal-hameed commented 8 years ago

@SandroMachado I think Json marshaling/unmarshaling does't depends on fields but getters/setters. What do you think?