Sandstorm-Station / Sandstorm-Station-13

A fork of SS13 of the Citadel Station flavor, it's a little pet project and whatever to play with, it is NSFW and has lead to the creation of a very terrible fork.
GNU Affero General Public License v3.0
9 stars 439 forks source link

Fixes text effects for runechat. #370

Closed SandPoot closed 6 months ago

SandPoot commented 7 months ago

About The Pull Request

This stuff has been cramping 100% heavy roleplay style for too long.

Somehow, the way maptext is formatted* seems to break tag ends found around a line break. This usually happens when a space with width is found by the end of the line, and I don't recall ever encountering the issue otherwise. Apparently, I've also found out that concatenating two spaces, regardless of width, seems to fix the issue just fine, and that brings in the solution to this whole pedantic problem: a zero-width space at the end of the closing tag.

*That's handled behind the curtains by the engine, so I can only throw wild guesses to why it happens.

Oh, by the by, I've also changed the tip about text modifiers I've made over a year ago. It was too confusing to read.

Why It's Good For The Game

Comparison between before and after, and how it looks in the UI. image

A Port?

Port of tgstation#81170

Changelog

:cl: fix: Fixed text effects for runechat messages (the stuff enclosed in +, | and _ characters). spellcheck: Improved the tip for say/text effects. /:cl: