SaneEngineer / No-Grass-In-Objects-NG

NGIO ported to AE
MIT License
32 stars 5 forks source link

Cannot generate cache when passing empty string to `Only-pregenerate-world-spaces` ini value #11

Closed sessionsdev closed 2 months ago

sessionsdev commented 2 months ago

There is either a bug or an error in ini documentation.

The ini text states:

########################################################################################################################
#   Only pregenerate world spaces                                                                                      #
#                                                                                                                      #
# If this is not empty then skip every worldspace that isn't in this list.                                             #
#                                                                                                                      #
#    Type: (string)                                                                                                    #
########################################################################################################################

When the Only-pregenerate-world-spaces = "", the plugin skips all worldspaces causing it to exit immediately with a success message. Removing the "" processes all worldspaces as expected.

I'm unfamiliar with C++ and how the ini gets deserialized, but this seems like null value is handled as expected, but empty string is being treated as a valid worldspace. Just a hunch.

sessionsdev commented 2 months ago

Just wanted to confirm I am using the latest 1.0.9 - New Config/Crash Fix version

Fizz508 commented 2 months ago

I can second this

alandtse commented 2 months ago

Ini files don't use " so an empty string is just blank.

Compare with Skip-pregenerate-world-spaces = DLC2ApocryphaWorld;DLC01Boneyard;WindhelmPitWorldspace

SaneEngineer commented 2 months ago

Looks like an oversight on my part, should be fixed no longer including an ini and generating comments with 2b9304e and 1.0.10