SaneEngineer / OpenVHook

Open source script hook loader implementation for Grand Theft Auto V
GNU General Public License v2.0
47 stars 7 forks source link

Error with current beta #21

Closed peterevertz closed 2 years ago

peterevertz commented 2 years ago

In a clean GTA V 2628.2 i copied Scripthook.dll, dinput8.dll (from latest, incompatible ScriptHook from Blade,)and two ASI scripts)

i got in OpenVHook.log:

[22:55:13] Kept OpenVHook reference: 00007FFED31F0000 [22:55:13] Registering script 'OpenInteriors.asi' (0x00007FFEEF970000!0x00007FFEEF97B950) [22:55:13] Initializing... [22:55:13] Registering script 'TrainerV.asi' (0x00007FFEBE550000!0x00007FFEBE9868B0) [22:55:17] Input hook attached: WndProc 0x00000000FFFF051B [22:55:17] Initializing ScriptEngine... [22:55:21] [Error] Unable to find scrThreadId [22:55:21] [Error] Failed to initialize ScriptEngine [23:00:20] Unregistered script 'TrainerV' [23:00:20] Unregistered script 'OpenInteriors' [23:00:20] Cleanup

asiload.log: // GTA V ASI LOADER (build May 2 2015) // (C) Alexander Blade 2015 LIB: "C:\WINDOWS\system32\dinput8.dll" => 00007FFEF2DF0000 API: "DirectInput8Create" => 00007FFEF2DF2230 API: "DllCanUnloadNow" => 00007FFEF2E05220 API: "DllGetClassObject" => 00007FFEF2E05330 API: "DllRegisterServer" => 00007FFEF2E14740 API: "DllUnregisterServer" => 00007FFEF2E149C0 LOADER: Loading .asi plugins ASI: Loading "D:\SteamLibrary\steamapps\common\Grand Theft Auto V\OpenInteriors.asi" "OpenInteriors.asi" => 00007FFEEF970000 ASI: Loading "D:\SteamLibrary\steamapps\common\Grand Theft Auto V\TrainerV.asi" "TrainerV.asi" => 00007FFEBE550000 LOADER: Finished loading .asi plugins

Don't hit me if it is a my error. I'am new to modding :)

loueslati commented 2 years ago

Hi dud i'm a newb too in modding but i might help u in this one so my guess is that ur using Scripthook.dll and dinput8.dll toghether witch cause the problem maybe use dsound or just scripthook in itself ?

SaneEngineer commented 2 years ago

It is unlikely that this is an issues with dinput8, make sure you are using version 0.8.5, as it is the only version the supports 2628.2 and is currently the most recent release of OpenVHook. Are you using steam, rockstar, or Epic?

peterevertz commented 2 years ago

I am sure it was version 0.8.5 Even build it myself, with same result.

I am using steam.

The pattern for finding the script thread seams to be wrong, for my setup. Tried some pattern found in other version of OpenVHook, but get only crashes.

I am willing to help, but i am more the *ix programmer. No knowledge about windows debuging/analyzing.

peterevertz commented 2 years ago

Additonal Info: I got some feedback on reddit about successful usage of this Version. They are on epic.

Maybe the binary ist different for steam and others?

As stated before: If i can help contact me.

SaneEngineer commented 2 years ago

Most likely the pattern is different on steam, usually there isn't a significant difference, but there is always a difference. I've been trying to figure the best way to find these patterns, so that I can have you check the steam version. I have limited knowledge about this stuff, the best I've got for now is for you to check the addresses 7FF7A67339D2 and 7FF7A67339D4 using cheat engine and take a screen shot if you browse the memory region.

pnwparksfan commented 2 years ago

Can confirm I also have Steam and the hook is not working.

pongo1231 commented 2 years ago

Can anyone test again with 1a80cdb9c4fc198447b99195c820e4cf97ea1e35? It should work with Steam now (automated build here).

IslandNull commented 2 years ago

I tested it using the Rockstar Launcher version and worked fine.

peterevertz commented 2 years ago

Tested standalone with steam version and trainer, and it works fine !

[02:41:42] Kept OpenVHook reference: 00007FFF708D0000 [02:41:42] Registering script 'OpenInteriors.asi' (0x00007FFFB83D0000!0x00007FFFB83DB950) [02:41:42] Initializing... [02:41:43] Registering script 'TrainerV.asi' (0x00007FFF65240000!0x00007FFF656768B0) [02:41:45] Input hook attached: WndProc 0x00000000FFFF0137 [02:41:45] Initializing ScriptEngine... [02:41:46] [Debug] INIT: IDXGISwapChain 0x00007FFFC809B108 Present:(0x00007FFFC8001FE0) [02:41:46] [Debug] INIT: IDXGISwapChain set [02:41:46] [Debug] scrThreadCollection 0x00007FF74B7B6610 (0x02DB6610) [02:41:48] [Debug] activeThreadTlsOffset 0x00000828 [02:41:49] [Debug] scrThreadId 0x00007FF74B7B5D28 (0x02DB5D28) [02:41:53] [Debug] scrThreadCount 0x00007FF74B7B5D5C (0x02DB5D5C) [02:41:54] [Debug] registrationTable 0x00007FF74B7B5520 (0x02DB5520) [02:41:54] [Debug] g_scriptHandlerMgr 0x00007FF74B05F130 (0x0265F130) [02:41:56] [Debug] gameState 0x00007FF74A9E7CD0 (0x01FE7CD0) [02:41:57] [Debug] g_globalPtr 0x00007FF74B7B6740 (0x02DB6740) [02:41:57] Game version #1715160166 [02:41:57] Initializing Pools... [02:41:58] [Debug] addressToEntity 0x00007FF749FE2108 (0x015E2108) [02:41:58] [Debug] pedPool 0x00007FF74AF6C0D0 (0x0256C0D0) [02:41:58] [Debug] objectPool 0x00007FF74AF796F8 (0x025796F8) [02:41:58] [Debug] pickupsPool 0x00007FF74AF57CD0 (0x02557CD0) [02:41:59] [Debug] vehiclePool 0x00007FF74B2C4F88 (0x028C4F88) [02:42:00] [Debug] entityPool 0x00007FF74B7B6ED8 (0x02DB6ED8) [02:42:00] Pool Init Finished [02:42:00] Checking if game is ready... [02:42:00] Game ready [02:42:00] [Debug] GtaThread collection size 189 [02:42:00] Registering script 'TrainerV.asi' (0x00007FFF65240000!0x00007FFF656768B0) [02:42:00] Registering script 'OpenInteriors.asi' (0x00007FFFB83D0000!0x00007FFFB83DB950) [02:42:01] [Debug] Created thread, id 1 [02:42:01] Initialization finished [02:43:02] Launching script TrainerV.asi [02:43:04] Launching script OpenInteriors.asi

Good job!

SaneEngineer commented 2 years ago

Since this appears to be fixed, I'm gonna close this issue if there are any compatibility issues put them in #2