search

Sangarshanan / geopatra

Interactive Maps with Geopandas
https://geopatra.readthedocs.io/
Apache License 2.0
51 stars 4 forks source link

Coloring points according to a 'color' column #28

Open krishnan-meep opened 3 years ago

krishnan-meep commented 3 years ago

https://github.com/Sangarshanan/geopatra/blob/db148e30bed5a2a99b2938f7090f0698b9b0984f/geopatra/folium/circle.py#L64-L67

Hi, I have an issue with the above. To me it looks like you can attach additional columns 'color' and 'fill_color' to your dataframe and then this function would color each point/circle accordingly. On these lines tho, the color and fill_color arguments of the function are being overwritten by the value of those columns for that row the first time this happens, so you're losing the name of the column you want to refer to for subsequent elements. I think it would work okay if you just changed the variable names there and in the folium.Circle call.

Sorry If I'm missing how it's supposed to be used.

Sangarshanan commented 3 years ago

oops !! you are right, figure this was what happens when you are too lazy to add proper test cases, Thanks for pointing this out. I think just prefixing the variable with _ should fix this

krishnan-meep commented 3 years ago

Cool, thanks!