SangeethKarunaratne / building-sat-

0 stars 0 forks source link

Landfill and salvage - ISSUE 1 #11

Closed Dilshi830 closed 2 years ago

Dilshi830 commented 2 years ago

Describe the bug If the user enters salvage % as 0% the rest of the fields are left blank. This should not be the case. Even if the user enters salvage % as 0%, the landfill % should be displayed as 100% and the calculation should proceed as normal to display the other field values. Also if the user changes the salvage% from a different value to 0%, then the calculation does not get adjusted accordingly.

To Reproduce Steps to reproduce the behavior:

  1. Go to Landfill and salvage
  2. Enter "0" to the salvage% field
  3. Or even if you enter a different value greater than 0% in salvage % and then later change salvage % to 0 then the calculation does not change.

Expected behavior This should not be the case. Even if the user enters salvage % as 0%, the landfill % should be displayed as 100% and the calculation should proceed as normal to display the other field values. Is it possible for all landfill entries to have the landfill % as 100% and salvage % as 0% by default. The user can then change these percentages if required and the calculation can be carried out.

Screenshots https://drive.google.com/file/d/1n9fjSg6pEYrPhmKvqi2VhlYCbur4h2fq/view?usp=drive_web

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

SangeethKarunaratne commented 2 years ago

Fixed