SangeethKarunaratne / building-sat-

0 stars 0 forks source link

Adding new material- Bulking factor #76

Closed Dilshi830 closed 2 years ago

Dilshi830 commented 2 years ago

Describe the bug Bulking factor- Is it possible to make it 1 for everything?

Service life - Add units next to'' Service life (years)''

Wastage - Add % next to '' Wastage'' Screenshot (34)

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Shiromikarunaratne commented 2 years ago

Pl extend this addition to all the 'manage resources" such as material, transport, mortar, water electricity etc. as applicable

Service life - Add units next to'' Service life (years)''

Wastage - Add % next to '' Wastage''

SangeethKarunaratne commented 2 years ago

Bulking factor- Is it possible to make it 1 for everything?

@Dilshi830 can set the default value as 1 for bulking_factor input, it this what you require for all places with bulking factor input?

Dilshi830 commented 2 years ago

This should be made possible only for new material entries made by the user. This should not be applied to existing data. For the administrator's side, we should be able to add in any value for bulking factor.

SangeethKarunaratne commented 2 years ago

@Dilshi830 This is fixed

Dilshi830 commented 2 years ago

I emptied the cache and hard reloaded and have tried entering the bulking factor for another value other than 1. it is possible. For a user the bulking factor should be fixed to 1 for all new materials that are entered. They should not be able to edit it.

https://user-images.githubusercontent.com/77833999/151771814-7f23e132-8ce2-4cd9-8203-74fd7b48d01e.mp4

Dilshi830 commented 2 years ago

Any update regarding this?

SangeethKarunaratne commented 2 years ago

@Dilshi830 Fixed