SangeethKarunaratne / building-sat-

0 stars 0 forks source link

FINAL RESULTS (DEMOLITION PHASE) - RESULTS SHOULD BE DISPLAYED SUB PHASE WISE #85

Closed Dilshi830 closed 2 years ago

Dilshi830 commented 2 years ago

Describe the bug Results of Demolition phase should be displayed subphase wise. As of now this does not appear - a big block for the entire phase appears. Kindly refer to before document by student for reference of what is needed. (Contribution of material, machinery, transportation, energy and water at each sub phase of demolition phase should be shown) Screenshot (112) Group 5-component 2.pdf

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

SangeethKarunaratne commented 2 years ago

Fixed empty cache and reload

Dilshi830 commented 2 years ago

It still does not work. Refer to both screenshots. First screen shot is after I empty cache and reload, the second screenshot is what is required to show. Screenshot (117)

Screenshot (116)

SangeethKarunaratne commented 2 years ago

@Dilshi830 This is how it is displayed now image

Dilshi830 commented 2 years ago

@SangeethKarunaratne I am referring to the final results demolition section. (Open poject> Results tab> Demolition phase) As of now, the demolition phase is displayed as one big block and the pie chart is also shown in all one color (refer to ss).

Is it possible to display the same chart displayed in the demolition phase (Open project > Demolition phase tab> Results) where the contribution has been broken down to sub activities i.e Electricity used on site, furel use don site, chemicals used on site and so on.

Apply the same to the Table view and the pie chart view. Screenshot (120) Screenshot (121)

SangeethKarunaratne commented 2 years ago

image image image image

@Dilshi830 refer to the attached screenshots, the agreement was to show the total emission of the main phases in the final results section. There was no such functionality before, you are simply referring to the screenshot of results under demolition phase.

Only main phase wise final total calculations was required to be displayed in the finial section, separated in to the 3 life cycle phases;

  1. Construction Phase
  2. Operation Phase
  3. Demolition Phase

Main phases

Unlike Operation phase, demolition phase doesn't have multiple main phases to it, demolition itself is a main phase and would only show the aggregated result of its sub phases:

  1. Electricity used on site
  2. Fuel use on site
  3. Chemicals
  4. Landfill and salvage

This was the expected behavior and how it was functioning before. Its not possible to do such a drastic change to the final calculation where its purpose was to show the aggregated results of the main phases.

Dilshi830 commented 2 years ago

Understood Mr Sangeeth. Just wanted to check the possibility. Then leave it as it functions as of now. Just a small query regarding the operation phase pie chart screenshot you have attached. Why does it total to 101.1%?

SangeethKarunaratne commented 2 years ago

@Dilshi830 pleasre refer to the attached screenshot Screenshot from 2022-01-29 13-26-34

The gwp for energy consumption is -304, and maintenance and replacement is 1110. The total would be 806.

Then 1110/806 * 100% = 137% A negative value cannot be shown in a pie chart.

Dilshi830 commented 2 years ago

Understood. Is it possible to display a message ONLY next to the Final results > Operation phase pie chart stating

"If the net energy consumption during the Operation phase is negative, the pie chart will not be displaying any negative values. Only positive values will be displayed on the pie chart"

SangeethKarunaratne commented 2 years ago

image

@Dilshi830 Right under the chart view accordion?

Dilshi830 commented 2 years ago

Final results> Operation phase> Chart view - Right next to/ above/ below the pie chart. This message is regarding the pie chart only so anywhere that shows connection to the pie chart is apporopriate.

Thank you

SangeethKarunaratne commented 2 years ago

@Dilshi830 Fixed