SangeethKarunaratne / building-sat-

0 stars 0 forks source link

Incorrect display of results in Demolition phase - Landfill and salvage #89

Closed Dilshi830 closed 2 years ago

Dilshi830 commented 2 years ago

Describe the bug Although there is no final results in machinery section of Landfill and salvage, when I hover over the bar the small percentage at the bottom shows contribution by macinery as 0.

Also, why cannot the material contribution be seen in the landfill and salvage bar? Screenshot (127)

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

SangeethKarunaratne commented 2 years ago

Duplicate of #80

@Dilshi830 not sure why you keep creating the same ticket over and over again

Dilshi830 commented 2 years ago

@SangeethKarunaratne I do not think its the same issue. Here, the machinery contribution is anyway zero. But in the bar chart, when i hover a small section indicates material contribution

SangeethKarunaratne commented 2 years ago

@Dilshi830 how can you display a -0.8 in a scale that has an interval in 500,000?

Dilshi830 commented 2 years ago

@Sangeeth I am not referring to material contribution. I am referring to machinery contribution. The machinery contribution is 0. Why is it that when i hover on the landfill and salvage bar (which DOES NOT have any machinery contributions) it shows that there is a machinery contribution.

Carefully look at the shown screenshot.

SangeethKarunaratne commented 2 years ago

@Dilshi830 it says the machinery contribution is 0 because it doesn't have machinery contribution, what is the issue with that?

Dilshi830 commented 2 years ago

But why is it shown in the bar chart if the contribution is zero?

For instance although material contribution in landfill and salvage is zero, this is not displayed in the bar chart which is correct.

But when i hover over the bar chart, although machinery contribution to landfill and salvage is zero, it is shown on the bar chart.

SangeethKarunaratne commented 2 years ago

"For instance although material contribution in landfill and salvage is zero, this is not displayed in the bar chart which is correct." @Dilshi830 material contribution is not zero look at the table, only machinery is zero.

The zero values are shown because the x axis starts at zero. Material contribution is not shown and will now be show because of its value -0.8