Landfill and salvage - calculation error (salvage quantity)

[Dilshi830]

Describe the bug When calculating the salvage quantity (tons), the equation (d) should be;

Salvage quantity (tons) = Quantity entered by user (in given unit) x (b/100) x adjusting factor x bulk density of salvage material

As of now everything else in this equation functions fine except when extracting the bulk density of salvage material, in all calculations it is used as 0.001 (I assume this is a misunderstanding as in the example calculation the salvage material bulk density is 0.001 but this should not be the case for the calculation of all other materials. Their respective bulk density should be extracted and used in this equation)

Please refer to screenshot attached. If further clarification required I can provide a manual calculation for another material. To Reproduce Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context Add any other context about the problem here.

[Dilshi830]

Any update regarding this?

[SangeethKarunaratne]

@Dilshi830 how many more issues #5 #11 #12 were closed like this without checking the functionality? If it was properly checked this issue this would have been brought up back then with the other issues. You even commented the calculation works. https://github.com/SangeethKarunaratne/building-sat/issues/5#issuecomment-958243726

[Dilshi830]

This calculation tallies with my manual calculation now. It seems to be fixed. Can i kindly get a confirmation @SangeethKarunaratne

[SangeethKarunaratne]

@Dilshi830 this was fixed