SanichKotikov / relatives-tree

A tiny library for calculating specific JSON data to family tree nodes and connectors 🌳
https://sanichkotikov.github.io/react-family-tree-example/
MIT License
45 stars 21 forks source link

Spacing not accounting for sibling spouse #11

Closed nichiang closed 2 years ago

nichiang commented 3 years ago

Hi, I'm seeing an issue where the spacing generated doesn't seem to be accounting for a sibling's spouse:

family_tree

SanichKotikov commented 3 years ago

Hi. Please, share the data to reproduce the issue.

nichiang commented 3 years ago

https://gist.github.com/nichiang/6e34513f069ef1340f536ef938b15b7a

It seems to have been due to a misconfigured root node on my part. Setting it to 957875050 yields the layout in the screenshot above, while setting it to -306296563 (the proper root node) lays things out correctly.

SanichKotikov commented 3 years ago

Ok, thx. I'll check when I'll have some time.

SanichKotikov commented 2 years ago

@harishdev22531 try to use v2.1.0

harishdev22531 commented 2 years ago

Hi,

Thanks for your support.

Regards Harish Kumar

On Mon, Oct 11, 2021 at 7:43 PM Sanich @.***> wrote:

@harishdev22531 https://github.com/harishdev22531 try to use v2.1.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SanichKotikov/relatives-tree/issues/11#issuecomment-940070754, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKFRPNKKHMG6XDJ2BUBIX3UGLWKBANCNFSM5BJWJOCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

SanichKotikov commented 2 years ago

Fixed and published (v3.0.2)