search

Sanjivkumarroshan / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Better logging on sipwakelock #2784

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Sometimes sipwakelock kept my phone awake for 70% of the time, and I don't know 
how to find out the problem.

I have some suggestions regarding this:

a. SipWakeLock.acquire() should add more log info about the reason of locking.
b. In "TimerWrapper.java", the TimerJob should not grab the wakelock in 
initialization, but when running it.

Thanks

Original issue reported on code.google.com by phtr...@gmail.com on 3 Oct 2014 at 11:14

GoogleCodeExporter commented 9 years ago 
Another suggestion: Add exception handling for failure in acquiring wakelock 
from system.

Many ROMs and MODs allow users to disable wakelock for a specific app, such as 
CM11 privacy guard, or xposed modules. Currently csipsimple will crash 
immediately. As an end user, I would rather take the risk of some misfunction 
due to lack of wakelocks, rather than crash on start.

Original comment by phtr...@gmail.com on 3 Oct 2014 at 11:37

GoogleCodeExporter commented 9 years ago 
I noticed the constant wakelock usually happens after network switched from 
wifi to cell or vice versa.

Original comment by phtr...@gmail.com on 11 Oct 2014 at 9:02

GoogleCodeExporter commented 9 years ago

Original comment by r3gis...@gmail.com on 22 Jun 2015 at 11:31