Open piyushswain opened 3 weeks ago
BTW Good Job!
Thanks for the feedback bro! I'll implement these changes. I wanted to ask few things -
On Fri, Sep 13, 2024 at 1:50 AM piyushswain @.***> wrote:
BTW Good Job!
— Reply to this email directly, view it on GitHub https://github.com/Sankalp20487/SankalpBiswal.github.io/issues/2#issuecomment-2348083687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOPAAHORJ2UXOQY7X5JLXDTZWJ4JFAVCNFSM6AAAAABOEUNVOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBYGA4DGNRYG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Thanks for the feedback bro! I'll implement these changes. I wanted to ask few things - 1. When you open my portfolio, does the first image get cropped out and interfere with Nav bar? 2. Can try to open this on your mobile and suggest some change that I can make to make this mobile friendly? … On Fri, Sep 13, 2024 at 1:50 AM piyushswain @.> wrote: BTW Good Job! — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOPAAHORJ2UXOQY7X5JLXDTZWJ4JFAVCNFSM6AAAAABOEUNVOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBYGA4DGNRYG4 . You are receiving this because you are subscribed to this thread.Message ID: @.>
Yes.
rem
instead of px
scale in your css everywhere. (1 rem = 10px) (But, rem
is relative to the rendered size of your root element, so it will scale accordingly on the rendered screen) (Never use px
).div
structure below your navbar element <div style="display: grid; grid-template-columns: 1fr 1fr; grid-gap: 2rem;">
<div name="left box"></div>
<div name="right box"></div>
</div>
rem
first and remove custom CSS or JS sizing from the code and then check the output
Just some small UI suggestions.