SankethBK / diaryvault

A personal diary application written in Flutter
https://play.google.com/store/apps/details?id=me.sankethbk.dairyapp
MIT License
91 stars 58 forks source link

Add new themes #13

Open SankethBK opened 1 year ago

SankethBK commented 1 year ago

Refer the documentation of themes.

To add a new theme

Start by altering the background image and colors of any existing theme, when its finalized create a new class in lib/app/themes/theme_extensions.

Reference PR for adding a new theme: https://github.com/SankethBK/diaryvault/pull/36

soam1 commented 11 months ago

@SankethBK would love to do that.

SankethBK commented 11 months ago

@soam1 Sure, you can use this PR as reference for adding new themes

ayato91 commented 11 months ago

@SankethBK I would like to contribute here :)

SankethBK commented 11 months ago

Sure @ayato91

vijaymehrotra commented 11 months ago

Hello @SankethBK , I want to contribute to this

SankethBK commented 11 months ago

Sure @vijaymehrotra

PratyushChauhan commented 11 months ago

Is anyone working on this?

SankethBK commented 11 months ago

@PratyushChauhan Multiple folks can work on this issue, since everyone will be creating their own theme. Feel free to pick it up and get creative with your unique ideas. You can use this as reference PR

Redvey commented 11 months ago

Hello I would also love to work on this

SankethBK commented 11 months ago

@Redvey sure

Redvey commented 10 months ago

@SankethBK Hey, I have made a PR that is adding a Dark Academia theme to the app, please do review.

TikuGaelle commented 8 months ago

Hello @SankethBK I would like to work on this issue.

SankethBK commented 8 months ago

@TikuGaelle sure, go ahead

TikuGaelle commented 8 months ago

Hello @SankethBK I have been trying to run the app for some day now but always get the errors below, please have any idea on how to resolve them?

`Launching lib\main.dart on AOSP on IA Emulator in debug mode... packages/flutter_quill/lib/src/widgets/raw_editor.dart:283:7: Error: The non-abstract class 'RawEditorState' is missing implementations for these members:

class RawEditorState extends EditorState ^^^^^^^^^^^^^^ ../../../flutter/packages/flutter/lib/src/services/text_input.dart:1051:12: Context: 'TextSelectionDelegate.lookUpEnabled' is defined here. bool get lookUpEnabled => true; ^^^^^^^^^^^^^ ../../../flutter/packages/flutter/lib/src/services/text_input.dart:1054:12: Context: 'TextSelectionDelegate.searchWebEnabled' is defined here. bool get searchWebEnabled => true; ^^^^^^^^^^^^^^^^ ../../../flutter/packages/flutter/lib/src/services/text_input.dart:1057:12: Context: 'TextSelectionDelegate.shareEnabled' is defined here. bool get shareEnabled => true; ^^^^^^^^^^^^ packages/flutter_quill/lib/src/widgets/raw_editor.dart:351:47: Error: Required named parameter 'onLookUp' must be provided. return EditableText.getEditableButtonItems( ^ ../../../flutter/packages/flutter/lib/src/widgets/editable_text.dart:1867:38: Context: Found this candidate, but the arguments don't match. static List getEditableButtonItems({ ^^^^^^^^^^^^^^^^^^^^^^ packages/flutter_quill/lib/src/widgets/quill_single_child_scroll_view.dart:289:18: Error: The method '_RenderSingleChildViewport.getOffsetToReveal' has fewer named arguments than those of overridden method 'RenderAbstractViewport.getOffsetToReveal'. RevealedOffset getOffsetToReveal(RenderObject target, double alignment, ^ ../../../flutter/packages/flutter/lib/src/rendering/viewport.dart:126:18: Context: This is the overridden method ('getOffsetToReveal'). RevealedOffset getOffsetToReveal( ^ packages/flutter_quill/lib/src/widgets/quill_single_child_scroll_view.dart:289:18: Error: The method '_RenderSingleChildViewport.getOffsetToReveal' doesn't have the named parameter 'axis' of overridden method 'RenderAbstractViewport.getOffsetToReveal'. RevealedOffset getOffsetToReveal(RenderObject target, double alignment, ^ ../../../flutter/packages/flutter/lib/src/rendering/viewport.dart:126:18: Context: This is the overridden method ('getOffsetToReveal'). RevealedOffset getOffsetToReveal( ^ Target kernel_snapshot failed: Exception

FAILURE: Build failed with an exception.

BUILD FAILED in 1m 29s`

SankethBK commented 8 months ago

Hi @TikuGaelle , can you share the Flutter version you're using

TikuGaelle commented 8 months ago

3.16.5 channel stable

SankethBK commented 8 months ago

Try with Flutter 3.13.0 • channel stable some of the packages we're using aren't compatible with 3.16 yet

TikuGaelle commented 8 months ago

Okay, thank you

TikuGaelle commented 8 months ago

Hi @SankethBK just made a PR, please review.