Open SankethBK opened 1 year ago
@SankethBK would love to do that.
@soam1 Sure, you can use this PR as reference for adding new themes
@SankethBK I would like to contribute here :)
Sure @ayato91
Hello @SankethBK , I want to contribute to this
Sure @vijaymehrotra
Is anyone working on this?
@PratyushChauhan Multiple folks can work on this issue, since everyone will be creating their own theme. Feel free to pick it up and get creative with your unique ideas. You can use this as reference PR
Hello I would also love to work on this
@Redvey sure
@SankethBK Hey, I have made a PR that is adding a Dark Academia theme to the app, please do review.
Hello @SankethBK I would like to work on this issue.
@TikuGaelle sure, go ahead
Hello @SankethBK I have been trying to run the app for some day now but always get the errors below, please have any idea on how to resolve them?
`Launching lib\main.dart on AOSP on IA Emulator in debug mode... packages/flutter_quill/lib/src/widgets/raw_editor.dart:283:7: Error: The non-abstract class 'RawEditorState' is missing implementations for these members:
class RawEditorState extends EditorState
^^^^^^^^^^^^^^
../../../flutter/packages/flutter/lib/src/services/text_input.dart:1051:12: Context: 'TextSelectionDelegate.lookUpEnabled' is defined here.
bool get lookUpEnabled => true;
^^^^^^^^^^^^^
../../../flutter/packages/flutter/lib/src/services/text_input.dart:1054:12: Context: 'TextSelectionDelegate.searchWebEnabled' is defined here.
bool get searchWebEnabled => true;
^^^^^^^^^^^^^^^^
../../../flutter/packages/flutter/lib/src/services/text_input.dart:1057:12: Context: 'TextSelectionDelegate.shareEnabled' is defined here.
bool get shareEnabled => true;
^^^^^^^^^^^^
packages/flutter_quill/lib/src/widgets/raw_editor.dart:351:47: Error: Required named parameter 'onLookUp' must be provided.
return EditableText.getEditableButtonItems(
^
../../../flutter/packages/flutter/lib/src/widgets/editable_text.dart:1867:38: Context: Found this candidate, but the arguments don't match.
static List
FAILURE: Build failed with an exception.
Where: Script 'C:\Users\brend\flutter\packages\flutter_tools\gradle\src\main\groovy\flutter.groovy' line: 1350
What went wrong: Execution failed for task ':app:compileFlutterBuildDebug'.
Process 'command 'C:\Users\brend\flutter\bin\flutter.bat'' finished with non-zero exit value 1
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
Get more help at https://help.gradle.org
BUILD FAILED in 1m 29s`
Hi @TikuGaelle , can you share the Flutter version you're using
3.16.5 channel stable
Try with Flutter 3.13.0 • channel stable
some of the packages we're using aren't compatible with 3.16 yet
Okay, thank you
Hi @SankethBK just made a PR, please review.
Refer the documentation of themes.
To add a new theme
lib/app/themes/coral_bubble_theme.dart
can be reused. If its a dark theme, most of the colors fromlib/app/themes/cosmic_theme.dart
can be re-usedStart by altering the background image and colors of any existing theme, when its finalized create a new class in
lib/app/themes/theme_extensions
.Reference PR for adding a new theme: https://github.com/SankethBK/diaryvault/pull/36