SankethBK / diaryvault

A personal diary application written in Flutter
https://play.google.com/store/apps/details?id=me.sankethbk.dairyapp
MIT License
74 stars 57 forks source link

Completed the PIN Based Authentication in the settings feature! #161

Closed LujainAlMansoori closed 7 months ago

LujainAlMansoori commented 7 months ago

What type of PR is this? (check all applicable)

Description

The PIN-based authentication feature is complete in the settings. The user is able to select to log in through a pin from the setting because we added a Enable PIN-based login. Once this takes place, a pop up comes up and collects the 4 digit pin from the user. We added a validation where only keyword numbers show up and we check if both PINs are matching, otherwise display error in a error message. Once that happens the user id and hashed pin is saved into a PINAuthRepository in the form of key:value pairs. This also resolves task 2 where the user can login through their userId if their userId is found in the flutter_storage, to which the userId is found with an associated hashed pin. The pin_login_form.dart involves utilizing an event from auth_form_bloc to ensure the user's pin is authenticated through pin_auth_repository.dart.

Featured Covered in this PR

Related Tickets & Documents

Screenshots, Recordings

Screenshot 2023-11-29 at 8 42 13 PM Screenshot 2023-11-29 at 8 42 21 PM Screenshot 2023-11-29 at 8 42 28 PM image image

This image shows when the pin is not the same as the user's saved pin:

image

Tested Feature??

SankethBK commented 7 months ago

Thanks for contributing! I'll review by tomorrow

LujainAlMansoori commented 7 months ago

Sure, thanks!

mbfannan commented 7 months ago

@SankethBK any updates?

LujainAlMansoori commented 7 months ago

Thanks for your changes, I will resolve them!

mbfannan commented 7 months ago

Hi @SankethBK, all changes have been resolved, hope everything is good thanks!

mbfannan commented 7 months ago

Hi @SankethBK and @LujainAlMansoori took me a while because some formatting and syntax errors didn't appear before, but everything should be alright now to merge thanks! Once it's merged I'll get on to issue #72 and I already got a start on it thanks!

SankethBK commented 7 months ago

Hey @mbfannan , I have added minor comments, I have changed the target branch to pin_authentication as we need to have part 2 as well before releasing it. Feel free to merge this to pin_authentication branch, you can resolve the comments later.

Thanks @mbfannan @LujainAlMansoori for your contribution!

mbfannan commented 7 months ago

Hey @mbfannan , I have added minor comments, I have changed the target branch to pin_authentication as we need to have part 2 as well before releasing it. Feel free to merge this to pin_authentication branch, you can resolve the comments later.

Thanks @mbfannan @LujainAlMansoori for your contribution!

Thanks yes sure! On it.

mbfannan commented 7 months ago

Hi @SankethBK, @LujainAlMansoori and I resolved task 1 for issue #71 and completed issue #72. Hope everything's alright to merge!

LujainAlMansoori commented 7 months ago

Yes @SankethBK , we completed both issues, issues #71 and #72 and they should be ready to be merged!

mbfannan commented 7 months ago

Hi, @SankethBK do you have any updates? We're doing this as part of a Software Engineering course at Carnegie Mellon University, and our deadline to continue contributing would be at the latest by tomorrow evening. So please let us know if we can help with any more changes to merge, thanks!

SankethBK commented 7 months ago

Hey @mbfannan I'll review in next 2-3 hours.

mbfannan commented 7 months ago

Hey @mbfannan I'll review in next 2-3 hours.

Great thanks!

SankethBK commented 7 months ago

This is great! thanks @mbfannan @LujainAlMansoori for choosing this project to contribute.