SankethBK / local_session_timeout

Redirect user to authentication page if the application doesn't receive any user interaction, or been running in the background for "x" duration.
https://pub.dev/packages/local_session_timeout
BSD 3-Clause "New" or "Revised" License
12 stars 19 forks source link

fix: added if(mounted) to all setState #17

Closed AbhishekDoshi26 closed 1 year ago

AbhishekDoshi26 commented 1 year ago

fix: Fixed keys to use the latest conventions fix: added if(mounted) to all setState

This PR fix #16

AbhishekDoshi26 commented 1 year ago

@SankethBK it would be great if you merge this and publish a new version. We are using your package in a production app and this is a critical bug.

Thanks!

SankethBK commented 1 year ago

I see this is a valid usescase, I assumed SessionTimeoutManager will always be at root of the widget tree and can never get mounted, but this may not be the case always. Thanks for the contribution

AbhishekDoshi26 commented 1 year ago

Thanks 🙌🏻 It would be great if a new version of package is published. Otherwise I will have to use my git version 😓

SankethBK commented 1 year ago

Published 👍