search

Sannis / node-mysql-libmysqlclient

Asynchronous MySQL binding for Node.js
http://sannis.github.com/node-mysql-libmysqlclient
Other
229 stars 47 forks source link

compatibility breaking with node v0.10.0 #172

Closed snehakoti closed 10 years ago

snehakoti commented 11 years ago

nvm use 0.10.0 npm install

make: Entering directory/home/sneha/Projects/node-mysql-libmysqlclient/build' CXX(target) Release/obj.target/mysql_bindings/src/mysql_bindings.o CXX(target) Release/obj.target/mysql_bindings/src/mysql_bindings_connection.o CXX(target) Release/obj.target/mysql_bindings/src/mysql_bindings_result.o ../src/mysql_bindings_result.cc: In static member function ‘static MysqlResult::fetch_options MysqlResult::GetFetchOptions(v8::Local)’: ../src/mysql_bindings_result.cc:235:25: warning: missing initializer for member ‘MysqlResult::fetch_options::results_as_array’ [-Wmissing-field-initializers] ../src/mysql_bindings_result.cc:235:25: warning: missing initializer for member ‘MysqlResult::fetch_options::results_nest_tables’ [-Wmissing-field-initializers] ../src/mysql_bindings_result.cc: In static member function ‘static v8::Handle MysqlResult::FetchAll(const v8::Arguments&)’: ../src/mysql_bindings_result.cc:461:25: warning: missing initializer for member ‘MysqlResult::fetch_options::results_as_array’ [-Wmissing-field-initializers] ../src/mysql_bindings_result.cc:461:25: warning: missing initializer for member ‘MysqlResult::fetch_options::results_nest_tables’ [-Wmissing-field-initializers] ../src/mysql_bindings_result.cc: In static member function ‘static v8::Handle MysqlResult::FetchRowSync(const v8::Arguments&)’: ../src/mysql_bindings_result.cc:720:25: warning: missing initializer for member ‘MysqlResult::fetch_options::results_as_array’ [-Wmissing-field-initializers] ../src/mysql_bindings_result.cc:720:25: warning: missing initializer for member ‘MysqlResult::fetch_options::results_nest_tables’ [-Wmissing-field-initializers] CXX(target) Release/obj.target/mysql_bindings/src/mysql_bindings_statement.o SOLINK_MODULE(target) Release/obj.target/mysql_bindings.node SOLINK_MODULE(target) Release/obj.target/mysql_bindings.node: Finished COPY Release/mysql_bindings.node make: Leaving directory /home/sneha/Projects/node-mysql-libmysqlclient/build'

make test

MysqlConnectionQueued.prototype = new bindings.MysqlConnection();
                                              ^
TypeError: Cannot read property 'MysqlConnection' of null
    at Object.<anonymous> (/home/sneha/Projects/node-mysql-libmysqlclient/lib/mysql-libmysqlclient.js:208:47)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/sneha/Projects/node-mysql-libmysqlclient/tests/config.js:21:25)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)```
Sannis commented 11 years ago

Thanks for your report. It was broken in some previous 0.9.x release. I'll try to fix it soon.

juan77 commented 11 years ago

Hi, I have the same problem, but on node 0.8.22 too. Currently I'm running ML 10.8.3 with MySQL 5.6.10

Last week I was running with ML 10.8.2 with MySQL 5.5.22 and node 0.8.10 and worked fine...

Also of consideration now i'm running nvm... but I don't think that this is the reason...

any ideas?

juan77 commented 11 years ago

I have managed to run on ML by adding a simlink

sudo ln -s /usr/local/mysql/lib/libmysqlclient.18.dylib /usr/lib/libmysqlclient.18.dylib

Apparently isn't node-mysql-libmysqlclient fault, the bindings was because can't found this dylib file.

Sannis commented 10 years ago

Builds well now, at least after 89baf73ca3fb5fd9711fab8f88b602a262491c51.

But tests still fails some time: https://travis-ci.org/Sannis/node-mysql-libmysqlclient/jobs/18046835.