search

Sannis / node-mysql-libmysqlclient

Asynchronous MySQL binding for Node.js
http://sannis.github.com/node-mysql-libmysqlclient
Other
229 stars 47 forks source link

Adaptations to nan 2.2.1 #192

Closed Will-I4M closed 7 years ago

Will-I4M commented 8 years ago

The first commit is an error, my apologies. Please give me your feedback

Sannis commented 8 years ago

@Will-I4M I've cherry-picked your commit to node-four-update branch and do some code style fixes. It is still broke Travis build, working to fix it.

cevek commented 8 years ago

+1

Will-I4M commented 8 years ago

Thanks, another version is comming, with better performances on fetch (~3x). I'm just waiting before push because i'm working on a faster method to build the v8 objects (as we can expect in some cases 10x or more). I'm not sure to understand this error with travis. Need help ?

cevek commented 8 years ago

Can you also check it with nightly node 6 https://nodejs.org/download/nightly/

Will-I4M commented 8 years ago

I'm quite sure the code need some changes to be v6 ready. For example : https://github.com/nodejs/nan/issues/548 -> the callback APi has changed. I'll check it but not in the next few days ;)

cevek commented 8 years ago

@Will-I4M How can I install this module from your PR?

Will-I4M commented 8 years ago

Sorry for this late answer ... You can install it from my fork, if you need it now. I'll try to push the next release this we, or next week.

cevek commented 8 years ago

Any updates?

Sannis commented 7 years ago

I've continue fixing this in node-nan-update branch, feel free to make further pull request on top of it.