search

Sansossio / twisted

Fetching riot games api data
124 stars 46 forks source link

BUG: League V4 Entries API should return LeagueEntryDTO[] #104

Closed ziyuanmw closed 9 months ago

ziyuanmw commented 9 months ago

Current

League V4 entries is parameterized to return LeagueEntryDTO. https://github.com/Sansossio/twisted/blob/master/src/apis/lol/league/league.ts#L52

return this.request<LeagueEntryDTO>(region, endpointsV4.LeagueEntries, params, false, { page })

On the Riot API docs, this API returns Set[LeagueEntryDTO]. https://developer.riotgames.com/apis#league-v4/GET_getLeagueEntries

Expected

League V4 entries should be paramterized to LeagueEntryDTO[].

return this.request<LeagueEntryDTO[]>(region, endpointsV4.LeagueEntries, params, false, { page })
Sansossio commented 9 months ago

feel free to open a pr!