search

Sansossio / twisted

Fetching riot games api data
125 stars 47 forks source link

[TFT] getBySummonerId #113

Closed NorbertLuszkiewicz closed 6 months ago

NorbertLuszkiewicz commented 7 months ago

Riot added new endpoint to getting summoner by summonerId, and changed in data from name to summonerId e.g. in challenger endpoint.

Request to add this endpoint as well as endpoints related to account_V1

rleaf commented 7 months ago

Hey I'm poking around in the TFT api and am having trouble finding the issues...

Riot added new endpoint to getting summoner by summonerId...

Could you share a link to it? I've tested encryptedAccountId, encryptedPUUID, encryptedSummonerId and they all work. Other than that, I'm not seeing a new endpoint added... (looking at TFT-SUMMONER-V1).

...changed in data from name to summonerId e.g. in challenger endpoint.

The relevant dto model seems to already have summonerId.

Request to add ... as well as endpoints related to account_V1

Sure, can work on a pr for get-active-shard