Sansossio / twisted

Fetching riot games api data
122 stars 46 forks source link

[TFT] Request for Interface to Retrieve Specific Tier and Division League Data #119

Closed SpicyCoffee closed 1 month ago

SpicyCoffee commented 1 month ago

Hi team,

First and foremost, thank you for your great open-source project!

I am looking to obtain TFT match data for a specific tier and division, such as matches in "DIAMOND IV." Based on my understanding, the following APIs should be utilized to achieve this:

I have found interfaces within your project to request Riot APIs, specifically TftApi.Summoner.getById, TftApi.Match.list, and TftApi.Match.get, but I did not find an equivalent for the first API. While I am able to retrieve summoner IDs for tiers above Master using TftApi.League.getFooLeague, I am unable to do so for tiers below Diamond.

Are there any interfaces or methods available to achieve this? If there are plans to develop this feature in the future, could you share the roadmap with me?

Thank you!

SpicyCoffee commented 1 month ago

The code was more straightforward than I initially thought, and I was able to easily add the implementation, so I have created a PoC PR. I would appreciate it if you could review it.

SpicyCoffee commented 1 month ago

Hi @Sansossio ,

I hope you're doing well. I wanted to follow up on the issue and PR I submitted. I understand that you may have a busy schedule, and I truly appreciate the time and effort you dedicate to maintaining this project.

When you have a moment, I would be grateful if you could take a look at the issue and PR. Your feedback and guidance would be invaluable in ensuring that the contribution aligns with the project's goals and standards.

Thank you very much for your time and consideration. Looking forward to your response.

Sansossio commented 1 month ago

@SpicyCoffee sorry for the delay, pr merged! and thanks for your contribution