search

Sansossio / twisted

Fetching riot games api data
125 stars 47 forks source link

type(matchV5): add ChallengesDto in ParticipantDto #95

Closed victorhurchella closed 1 year ago

victorhurchella commented 1 year ago

The information inside ChallengesDto is very helpful for any that uses MatchV5. I really missed this interface in the development of some parts of my project.

Sansossio commented 1 year ago

@victorhurchella the linter failed, please check it and update the version in package.json to deploy

codecov[bot] commented 1 year ago

Codecov Report

Merging #95 (977aed1) into master (eee376b) will increase coverage by 2.60%. Report is 44 commits behind head on master. The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   83.52%   86.13%   +2.60%     
==========================================
  Files          28       28              
  Lines         601      613      +12     
  Branches       75       69       -6     
==========================================
+ Hits          502      528      +26     
+ Misses         99       85      -14
Files Coverage Δ
src/base/base.const.ts 100.00% <ø> (ø)
src/base/base.ts 84.74% <100.00%> (-0.51%) :arrow_down:
src/constants/regions.ts 100.00% <100.00%> (+47.05%) :arrow_up:
src/endpoints/endpoints.ts 100.00% <100.00%> (ø)
src/constants/champions.ts 92.42% <85.71%> (-0.55%) :arrow_down:
victorhurchella commented 1 year ago

@Sansossio thanks, i fixed the issues and update package version.