Sansossio / twisted

Fetching riot games api data
124 stars 46 forks source link

Changes in past year (Garena regions, challenges-v1, account-v1) #99

Closed rleaf closed 9 months ago

rleaf commented 10 months ago

Hello.

I've been using & working on a fork of Twisted for a little over a year and wanted to submit a pr.

Changes/additions:

codecov[bot] commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eee376b) 83.52% compared to head (6560acf) 84.24%. Report is 46 commits behind head on master.

Files Patch % Lines
src/base/base.ts 66.66% 2 Missing :warning:
src/constants/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #99 +/- ## ========================================== + Coverage 83.52% 84.24% +0.71% ========================================== Files 28 30 +2 Lines 601 857 +256 Branches 75 125 +50 ========================================== + Hits 502 722 +220 - Misses 99 135 +36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sansossio commented 9 months ago

please update package json version

rleaf commented 9 months ago

I believe it already is from bf60b3a. Sorry if I've missed something.