search

SantiMA10 / devops-streamdeck

👀 Check the status of your CI/CD environments using your Stream Deck.
MIT License
99 stars 13 forks source link

Misleading icon on Netlify status #64

Open orestes opened 2 years ago

orestes commented 2 years ago

Love the project!

Ran into a small issue yesterday.

This is the status of the last builds for my project on Netlify:

image

However, the icon shows an "error" icon:

image

I would expect the icon to reflect the "cancelled" status instead.

It would also be nice if there was a way to preserve the last non-cancelled status instead of scaring me :)

Keep up the good work!

SantiMA10 commented 2 years ago

Any design proposals? 😇

orestes commented 2 years ago

I would keep the last non-cancelled status, like I proposed above. After all, the cancelled job did not create any side effects and that last status is still accurate.

I would imagine that's a bit problematic since you can't just check the last job, but the last n jobs instead until you find one that's not cancelled. If that's something that should be avoided, maybe use an empty gray icon, or even one with a question mark.

SantiMA10 commented 2 years ago

Ups! I misunderstand your initial comment 🤦

I made a quick check and that behavior you describe is the one it should have unless the Netlify API is considering the canceled status an error (code here) 🤔

SantiMA10 commented 2 years ago

If you want to debug what is happening and provide a solution in a PR, here is the documentation on how to debug the StreamDeck application: https://developer.elgato.com/documentation/stream-deck/sdk/create-your-own-plugin/#debugging 😇