search

SantioMC / MinehutUtils

The core behind the Minehut bot in discord.gg/Minehut
https://discord.gg/Minehut
Apache License 2.0
4 stars 6 forks source link

PAID and UNPAID tags in marketplace posts #13

Open WholeWheatLemon opened 1 year ago

WholeWheatLemon commented 1 year ago

Please add the ability to add a PAID or UNPAID tag to #offers-and-requests posts so you can quickly scroll through and find what you're looking for

ty bestie appreciate it

hapily04 commented 1 year ago

+1

Sniped commented 1 year ago

This could probably be a dropdown menu selection prompted after the user specifies whether they want the Offering or Requesting menu.

Additionally, I think it would look nice if it wasn't in the header, rather, it was below the header with an emerald emoji that said PAID or UNPAID. Just an idea though, if it's appealing enough I could try to PR it.

SantioMC commented 1 year ago

This seems interesting, do we have any thoughts on how the embed would look like if implemented? I do like the idea of having it an emerald emote, should there be any for non paid postings?

Sniped commented 1 year ago

should there be any for non paid postings?

Probably just use the emerald for both PAID and UNPAID, since the OP wanted to be able to filter between paid and unpaid easily (I think? I might've misread it, still would be nice to differentiate so the user could filter if they'd like).

I was thinking about just having an indicator for paid listings, though that would probably just be confusing as opposed to having the emerald heading show for both paid and unpaid listings.

SantioMC commented 1 year ago

I was thinking of using two different indicators between the two tags, something like the following unless you think it'll look nicer if it was the same emote

Emerald - Paid Listing Coal (or something similar) - Unpaid Listing (there'll also be text to both emotes)

Sniped commented 1 year ago

Coal sounds like a good idea. I just couldn't think of another emoji to go with emerald. Could try both ways out and see which is better.

SantioMC commented 1 year ago

Sounds good, I'll take a look into it later on, if someone wants to make a pull request feel free to, though the command is pretty messy since discordx doesn't work too well with command flows.

If not, I'll be taking a look into it likely sometime next week (?)

Sniped commented 1 year ago

I'll try to pick it up once https://github.com/SantioMC/MinehutUtils/pull/14 gets merged to master, can't test the bot otherwise and don't want to base the branch for this feature off of a yet to be merged one.