When installing despasito, the user must have numpy installed for the import to run. However, if the user does not have Cython installed, numpy will not be used anyway.
Todos
I propose moving the numpy import inside the same optional logic as Cython, and modifying the warning to be more explicit.
Questions
If you like this change, the README should also be updated to explain how numpy and Cython are optional for acceleration.
JacksonBurns
commented
2 days ago
Description
When installing
despasito, the user must havenumpyinstalled for the import to run. However, if the user does not have Cython installed,numpywill not be used anyway.Todos
I propose moving the
numpyimport inside the same optional logic as Cython, and modifying the warning to be more explicit.Questions
If you like this change, the README should also be updated to explain how
numpyand Cython are optional for acceleration.Status
Note
This PR is part of an ongoing JOSS review at https://github.com/openjournals/joss-reviews/issues/7365