search

Sapd / HeadsetControl

Sidetone and Battery status for Logitech G930, G533, G633, G933 SteelSeries Arctis 7/PRO 2019 and Corsair VOID (Pro) in Linux and MacOSX
GNU General Public License v3.0
1.47k stars 178 forks source link

Should \n be added to short output? #309

Closed Odizinne closed 7 months ago

Odizinne commented 1 year ago

Description

Hello, not sure if this is wanted or not but:

flora@pop-os:~$ headsetcontrol -b -c
-2flora@pop-os:~$

This is what i get when shortening output. Is this something intended?

I would expect something like this:

flora@pop-os:~$ headsetcontrol -b -c
-2
flora@pop-os:~$

On which OS does the problem happen?

Linux

Sapd commented 1 year ago

It probably was done this way to make it easier to directly parse. But I agree with you, normally a Linux command should always end with \n.

However, I wouldn't change it due to backwards compatibility. Also because -c will be probably deprecated in the future in favour of https://github.com/Sapd/HeadsetControl/issues/271 (Feel free to participate in the discussion)

Sapd commented 7 months ago

Closed because short output is now deprecated in favour of JSON/YAML output