search

Sapd / HeadsetControl

Sidetone and Battery status for Logitech G930, G533, G633, G933 SteelSeries Arctis 7/PRO 2019 and Corsair VOID (Pro) in Linux and MacOSX
GNU General Public License v3.0
1.43k stars 174 forks source link

Add Arctis Nova 3 support #319

Closed AnErrupTion closed 9 months ago

AnErrupTion commented 9 months ago

Hello! This PR adds support for the Arctis Nova 3 headset. Alongside this, it adds 2 new capabilities that this headset implements, those being the following:

The headset also implements the following existing capabilities:

Closes #294.

Sapd commented 9 months ago

Thank you!

-o probably has to be replaced with some other letter. As it will be used for output for a further release. Also I think you forgot to map the long names like --microphone-volume into struct option opts[] = { We could think about for the new functions, to maybe only map a long name and no short letter at all (can be done by leaving out the letter in getopt_long and implementing the function at case 0:; like done for --timeout)

AnErrupTion commented 9 months ago

Also I think you forgot to map the long names like --microphone-volume into struct option opts[] = {

Yup, haha! Good catch!

We could think about for the new functions, to maybe only map a long name and no short letter at all

That to me sounds like a better bet.