Sapd / HeadsetControl

Sidetone and Battery status for Logitech G930, G533, G633, G933 SteelSeries Arctis 7/PRO 2019 and Corsair VOID (Pro) in Linux and MacOSX
GNU General Public License v3.0
1.46k stars 178 forks source link

Added capabilities for Artic Nova 7 mirophone(tested and working) and… #356

Closed nicola02nb closed 5 months ago

nicola02nb commented 5 months ago

… volume limiter(tested and working); pre inserted instruction for bluetooth capabilities(tested,not working)

Changes made

Added features for Steelseries Artic Nova 7:

Pre added instructions to main.c, device.h and device.c for possible future implementation of:

Checklist

Sapd commented 5 months ago

I will do a make format before merging so dont worry about the code style.

The other commented out functions dont work at all?

nicola02nb commented 5 months ago

I will do a make format before merging so dont worry about the code style.

The other commented out functions dont work at all?

Oh cool, I will totally check it.

I tried the other functions, but they were not working... I try to see if they are an easy fix, but I haven't any experience on wireshark... may be it's time to give it a shot.

nicola02nb commented 5 months ago

I also forgot to put the help section for the new command...

nicola02nb commented 5 months ago

Updated the branch with new working features... I didn't got make format working, I hope it doesn't give any problem with the clang-format

nicola02nb commented 5 months ago

Can you explain me line 32 of the code style ceck?

Sapd commented 5 months ago

Can you explain me line 32 of the code style ceck?

Yeah there is a whitespace at the end of the line

-    if (num == 8) <-- here
+    if (num == 8)

But does not really matter, I will also fix the enum from above later and then also re run a format over it

nicola02nb commented 5 months ago

Can you explain me line 32 of the code style ceck?

Yeah there is a whitespace at the end of the line

-    if (num == 8) <-- here
+    if (num == 8)

But does not really matter, I will also fix the enum from above later and then also re run a format over it

Oh 😅

nicola02nb commented 5 months ago

Any info on first error?

Sapd commented 5 months ago

Looks fine to me. I think the whitespace check is quite simple and just does a diff to the commit before. It just sees that there is a diff and that its why it outputs it. It will probably go away when I merge it later.

nicola02nb commented 5 months ago

Ok, I hope I wasn't an issue with all this commits 😅

Sapd commented 5 months ago

Thank you! well done