SapientGuardian / mysql-connector-net-netstandard

ADO.NET driver for MySQL targeted against netstandard 1.3
GNU General Public License v2.0
46 stars 15 forks source link

Fixed keywords resource #12

Closed SapientGuardian closed 8 years ago

SapientGuardian commented 8 years ago

This MR restores functionality of the Keywords resource.

SapientGuardian commented 8 years ago

@IntelOrca your sample repro no longer crashes with this version. Do you have a larger context you can test this in, or is that yet to be written?

IntelOrca commented 8 years ago

I do, but I won't be able to test that until tomorrow evening. Would it be okay for you to tag another build with this fix?

SapientGuardian commented 8 years ago

Will do. Even if this doesn't fix your scenario, I suspect there are others that will be helped by this.

IntelOrca commented 8 years ago

With the test project from #10 I now get

Unhandled Exception: System.ArgumentNullException: Value cannot be null.
Parameter name: stream
   at System.IO.StreamReader..ctor(Stream stream, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean leaveOpen)
   at MySql.Data.MySqlClient.Properties.Resources.LoadKeywords()
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at MySql.Data.MySqlClient.MySqlCommand.AddCallStatement(String query)
   at MySql.Data.MySqlClient.MySqlCommand.ExecuteReader(CommandBehavior behavior)
   at MySql.Data.MySqlClient.MySqlCommand.ExecuteNonQuery()
   at MySql.Data.MySqlClient.MySqlConnection.BeginTransaction(IsolationLevel iso)
   at ConsoleApplication.Program.Main(String[] args)

I will investigate...

IntelOrca commented 8 years ago

https://github.com/SapientGuardian/mysql-connector-net-netstandard/blob/6.9_netstandard/Source/MySql.Data/Properties/Resources.Designer.cs#L630

This might need to be changed to SapientGuardian.MySql.Data.Properties.keywords.txt

SapientGuardian commented 8 years ago

Well that's annoying. Fixing...

SapientGuardian commented 8 years ago

Fixed in SapientGuardian.MySql.Data 6.9.8-rc2-006

IntelOrca commented 8 years ago

thanks, it works now!