Closed SapientGuardian closed 8 years ago
The async void signature of the Open method made it impossible for callers to catch exceptions in the correct context. This PR removes async and adds .wait() in Open() so exceptions can be caught. It also simplifies our ifdefs.
The async void signature of the Open method made it impossible for callers to catch exceptions in the correct context. This PR removes async and adds .wait() in Open() so exceptions can be caught. It also simplifies our ifdefs.