Sappharad / mp3gainOSX

MP3Gain Express for macOS
http://projects.sappharad.com/mp3gain/
96 stars 9 forks source link

Album Gain Support #13

Closed skattman closed 7 years ago

skattman commented 11 years ago

I think your interface is much more polished than the other options for OS X, unfortunately, I need the ability to use the album gain feature of MP3Gain. Is this a feature you'd be willing to consider implementing?

Sappharad commented 11 years ago

It would be very easy to implement this feature. It's just one of those things where I've never wanted it, so it hasn't been a priority to me. I usually listen to a lot of music on shuffle, so balancing the entire album as a whole was never something I wanted.

It's likely that I will add this at some point, simply because it wouldn't take very long.

Flopsy007 commented 11 years ago

Hi, just discovered Mp3gain Express. Have really been missing this for OSX (have been using Mp3gain on a virtual Windows machine since I converted to Mac some years ago). I am however always using the album gain option.

Please, please, PLEASE add album gain to Mp3gain Express. I am holding my breath until that happens, so you would practically save my life ;) If you do, maybe add a donation option and I'll be the first in line...

Sappharad commented 11 years ago

As I stated above, this is one of the easier things to add. It will probably be one of the first things I add the next time I decide to update this. I can't give any estimate of when that will be, other than "probably this year"

gith-account commented 7 years ago

Hi, could this be implemented, please? The port is great otherwise, but album gain is definitely missing and it would be a pity to have to create another port only for this, especially since you have mentioned that it would be rather easy for you to add.

Sappharad commented 7 years ago

I don't see why someone would need to "create another port" for that, this one is open source and they could just add it themselves and submit a pull request. I don't mind if someone else wants to do a better job. There was already another port available when I started this one, but it was abandoned and just an AppleScript wrapper around an old command-line build.

Regarding an update on this, I actually partially finished adding album gain last July. The GUI changes were done and Analyze was implemented, but not Apply Gain. However, I paused before finishing it because the way I had originally decided to integrate the port with MP3Gain's code made it difficult to get the progress status back to the UI. It also made some other feature requests like multi-threaded processing impossible. I decided to completely rewrite the backend to make multi-core processing possible, (which the Windows version doesn't even do) and made it as far as working proof of concept where I could analyze multiple files at a time but didn't have a new UI for that yet. I got busy and haven't touched it since August though. Also, multi-core and album gain are mutually exclusive, because album gain just treats multiple tracks as a single track so you can't process multiple files at once anyway, but I need to finish those changes before I can hook up Album gain to the new backend. I have no idea at this point when I'll finally resume working on the rewrite, but every time I get a reminder like this it helps.

At the moment, your best option is just to use the command-line build which is also available for download on the website. That has all functionality of MP3Gain including AACGain support, you just have to know how to use the terminal.

gith-account commented 7 years ago

I don't see why someone would need to "create another port" for that, this one is open source and they could just add it themselves and submit a pull request.

You are absolutely right about that. Sorry, that was poor wording on my behalf.

I am not a programmer myself and a newcomer to MacOS. Adding this feature to your port is beyond my skills. My alternate strategy would be to take your command line build (thanks a lot for that, btw.), look into AppleScript and see what I can achieve. That is a frustrating thought for me, because I will probably be putting a lot of work into something that may or may not work, with zero chance to achieve something nice like your tool, which does the job great and is only missing this tiny bit (or let's say tiny bits, because the other feature request also make sense). This is where the "to have to create" part came from. I mixed up several thoughts there.

I don't mind if someone else wants to do a better job.

I would like it better if that (hypothetical) someone put his or her effort into contributing to your port. There are, of course, many good reasons for starting new projects around the same problem, but in this case collaborating with you on your port, which is close to being feature complete, would be the better thing to do, imho.

I would like to apologize if I came across as rude or made it look like I did not appreciate your work. I am super happy that you created a build of the command line tool and that your are still actively working on the graphical tool. Thanks a lot for all your work!

Sappharad commented 7 years ago

Here's a status update. I started working on this again recently. The backend changes necessary to support multi-core processing, album gain and AAC support are mostly done now. Since multiple files can be processed at once, the UI for that has changed to what's pictured below.

m3g_multicore

Everything still needs to be hooked back up, (only Analyze does something in my current development build) but the hardest part is done. A new release could still end up being a month or more away depending on how often I work on it, but I don't think it should be very long now.

Since I significantly changed how things work internally, I might release a beta for people to try out before doing the next release to make sure I didn't break anything. I'll post here if / when I have more news.

Sappharad commented 7 years ago

Added in 05ed8d73ab206d093d3b141d150d82ac0c737148. This will be closed when 2.0 is released.

Sappharad commented 7 years ago

If you want to try it, MP3Gain Express 2.0 beta (which is version 1.9 in the About box so that Check for Updates will work correctly when 2.0 is actually released) can be downloaded here: http://projects.sappharad.com/mp3gain/mp3gain_mac19beta.zip

I don’t think it should damage anything, and the Undo feature is still hiding under the little arrow menu, but it’s always a good idea to test with a copy of the files instead of originals until you’ve determined that the program works correctly.

Changes:

Known problems:

If you decide to try it, please let me know if it appears to still work fine or if you run into problems. Version 2.0 will not be released until I've added a few more features, and confirmed that the program is still working correctly after all of the changes I made.

StarlightDesign commented 7 years ago

Thanks for following up, that newer beta version is back up and running. It's much appreciated!

Sappharad commented 7 years ago

MP3Gain Express 2.0 has been released.