Sappharad / mp3gainOSX

MP3Gain Express for macOS
http://projects.sappharad.com/mp3gain/
96 stars 9 forks source link

Missing Progress Bars in OS X 10.7 (MP3Gain Express 2.0) #17

Closed Sappharad closed 7 years ago

Sappharad commented 7 years ago

I'm logging this so that I have a record of it.

When running the 2.0 development builds on OS X 10.7, the progress bar displayed for each file as they process is missing. The total progress bar at the bottom of the window is there, but it will disappear too if you resize the status window.

I've looked into this for several hours, tried disabling Auto Layout, changing view settings, etc. Ran out of ideas how to fix it and found no references to a similar problem online. I assume it's related to developing against newer tools where something related to progress indicators has changed such that resizing breaks constraints, but this is just a theory.

Sappharad commented 7 years ago

For the 2.0 release, I've worked around this problem in commit e68e56224e062664edb4fde80ecda8a2660de577.

I didn't test on 10.8 or 10.9 to see if the problem occurs there, but I'm assuming 10.10 and newer are fine. If macOS older than 10.10 is detected, I use an NSLevelIndictor instead of NSProgressIndicator. This can look like a progress bar except it's green. It appears correctly on the older OS versions.

Note that I only used this for the individual file progress and not the overall total, because the individual files were not appearing at all. Since the total only disappears when you resize the window, and you can still tell how far it is by looking at the individual files, I don't think it's necessary for me to fix this problem. If I ever drop support for anything older than 10.10 the work around shouldn't be necessary anymore.