search

Sappharad / mp3gainOSX

MP3Gain Express for macOS
http://projects.sappharad.com/mp3gain/
96 stars 9 forks source link

Dark Theme displays incorrectly with "Increase Contrast" enabled #20

Closed Sappharad closed 7 years ago

Sappharad commented 7 years ago

Turning on the "Increase Contrast" option in Accessibility settings causes the grid text color to be black, resulting in black text on a black background that you can't read.

This seems like a bug with macOS dark vibrancy layers, but I'll see if I can work around it. Might also need to file a radar with Apple for them to fix it if it does turn out to be an OS problem.

Sappharad commented 7 years ago

I produced a stand-alone project that uses Vibrancy layers "correctly" and it doesn't have this problem. This tells me that the hack I implemented to apply dark mode automatically is probably causing the problem. Messing with the settings on the vibrancy layer doesn't seem to help.

The user who reported the bug didn't realize they had the increase contrast option enabled and was satisfied with just turning the option off. I want to fix this though, even if it means just disabling dark mode for high contrast. I will continue to play around with this at a later time.

Sappharad commented 7 years ago

I disabled dark mode in combination with Increase Contrast. While it would have been nice to actually fix it, at the moment I don't have time to look into it.