Sappharad / mp3gainOSX

MP3Gain Express for macOS
http://projects.sappharad.com/mp3gain/
96 stars 9 forks source link

Undo no longer works with multiple files #28

Closed Sappharad closed 4 years ago

Sappharad commented 4 years ago

When background processing was cleaned up in 2.3, the undo feature broke and it stops processing after the first file(s). The number of files depends on how many threads you were using, 4 is the most common default for most machines. Bug reported last month via email.

Sappharad commented 4 years ago

This was introduced when I attempted to clean up memory management to prevent leaks. Undo was never updated with the same changes as Analyze and Apply, so after the first file gets done processing it tries to remove it from the common pending files list but there was no pending files list to remove it from.